Port the op_str short-circuit and subprocess test52 from #56 - #3
Merged
Conversation
The in-process test52 crashed the llvm22 and cling CI lanes with a SIGSEGV, hiding the rest of the suite. Match compiler-research#56's head: the cling pretty-print path in op_str now compiles out entirely behind CPPJIT_USE_CLING on clang-repl, with the matching CMake compile-definition wiring, and the regression test runs its repro in a subprocess so a crash fails the assertion instead of the runner. Co-developed-with-the-help-of: Claude Code (Sonnet 5, human in the loop)
Test Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test52crashed the llvm22 and cling CI lanes with a SIGSEGV, which hid the rest of the suite's results — the current red tracking cells on every run.op_strnow compiles out behindCPPJIT_USE_CLINGon clang-repl (with the matching CMake compile-definition wiring), andtest52runs its repro in a subprocess, so a regression fails the assertion instead of killing the runner.//:test_regressionpasses on thectc-mastertip (49 passed, 1 skipped, 1 xfailed unrelated);bazelisk build //...builds clean; astringscheck on the builtlibcppjit.soconfirms the gated block compiles out.🤖 Done with the help of Claude Code (Sonnet 5, human in the loop)