Add PSADT template #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
∙ ∙ This change adds a template for generating Chocolatey packages ∙ from a PSADT application. ∙ ∙ PSAppDeployToolkit is a framework for generating an executable with ∙ silent installation parameters via PowerShell.
TheCakeIsNaOH
requested changes
Feb 5, 2023
| statements = "-DeploymentType 'Uninstall' -DeployMode 'Silent'" | ||
| } | ||
|
|
||
| Start-ChocolateyProcessAsAdmin @packageArgs |
There was a problem hiding this comment.
I'd suggest switching to Uninstall-ChocolateyPackage if possible, as that has support for valid exit codes.
| $destination = (Join-Path $toolsDir -ChildPath $env:ChocolateyPackageName) | ||
|
|
||
|
|
||
| $adtExe = Join-Path $destination -ChildPath "Deploy-Application.exe" |
There was a problem hiding this comment.
Does this deploy-application.exe needed to be excluded from the package reducer?
| <!-- Do not remove this test for UTF-8: if “Ω” doesn’t appear as greek uppercase omega letter enclosed in quotation marks, you should use an editor that supports UTF-8, not this one. --> | ||
| <package xmlns="http://schemas.microsoft.com/packaging/2015/06/nuspec.xsd"> | ||
| <metadata> | ||
| <id>psadt-silent.template</id> |
There was a problem hiding this comment.
Since all Chocolatey packages should be silent, this could be simplified to psadt.template
| <version>1.0.0</version> | ||
| <packageSourceUrl>https://github.com/chocolatey-community/chocolatey-templates/tree/main/src/psadt-silent.template</packageSourceUrl> | ||
| <owners>Stephen Valdinger, Chocolatey-Community</owners> | ||
| <title>PSADT Template</title> |
There was a problem hiding this comment.
Suggested change
| <title>PSADT Template</title> | |
| <title>PSAppDeployToolkit Template</title> |
|
|
||
| Install-ChocolateyInstallPackage @packageArgs | ||
| } catch { | ||
| $packageArgs = @{ |
There was a problem hiding this comment.
What is the reason this catch block is needed? It seems to be doing pretty much the same thing as the try block.
| $zipArchive = Join-Path $toolsDir -ChildPath '[[Zip]]' | ||
| $destination = (Join-Path $toolsDir -ChildPath $env:ChocolateyPackageName) | ||
|
|
||
| Get-ChocolateyUnzip -FileFullPath $zipArchive -Destination $destination |
There was a problem hiding this comment.
Since the zip archive is embedded, it is probably best to include the license and verification template files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PSAppDeployToolkit is a great framework for generating deployable executables with silent arguments.
You can leverage these PSADT applications in Chocolatey packages if you zip them up and distribute them. This template helps a user create a Chocolatey package for PSADT applications.
Related: #5