(#74)(ENGTASKS-3605) Update ReadMe and Vagrantfile in preperation for release of new box version with Hyper-V provider #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hyper-v box can potentially have the max memory set lower than the desired amount of memory in the test environment Vagrantfile. Overring the max memory with `nil` enables any memory amount to be used. In testing, it also took longer than expected to for the box to get an IP address, and so the IP Address Timeout has been increased to give more time for this step to complete.
Windos
force-pushed
the
GH-74/hyper-v-notes
branch
from
6835d6b
to
0c05c9c
Compare
pauby
requested changes
Jun 19, 2024
|
@Windos I don't think we should merge this in until the box is on the Vagrant Cloud? |
|
Thanks for the review and suggested edits, @pauby, I agreed with and applied all of them. Agreed that this should be merged at the same time as the blog post and the boxes are released (those are ready to go now, thankfully) |
pauby
approved these changes
Jun 20, 2024
Add a section on using Hyper-V instead of VirtualBox, including a recommendation to prefer VirtualBox and linking to known limitations. This also updates the table of contents to include the newly added section as well as two sections added in a previous commit that were not added to the list.
pauby
force-pushed
the
GH-74/hyper-v-notes
branch
from
af32880
to
ed7f3ad
Compare
|
Thanks @Windos for getting this updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This PR includes two small tweaks to the Vagrantfile specific to the Hyper-V provider that came out of testing using Hyper-V to run the Chocolatey Test Environment. Specifically, it increases the timeout for getting an IP address when first booting the image and it also sets the "maximum memory" to
nilso that the user can specify any amount of memory as allowed by their available resources.It also updates the ReadMe with information specific to running this testing environment under Hyper-V, including warning about the limitations that may be encountered while doing so.
Motivation and Context
We're about to release v3.2.0 of the Vagrant box used by this test environment and re-introduce a Hyper-V version of the box.
Testing
These changes come as a result of testing the new Hyper-V provider version of the test-environment box (v3.2.0).
Operating Systems Testing
N/A
Change Types Made
Change Checklist
Related Issue