Add embedded elisp evaluation per-template option #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have fixed the build issue in below commit. You can merge this change to your branch, or I can submit a new pull request. |
|
@tendant, I've merged your commit and Jenkins checks are ok now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into issue when I get
Stack overflow in regexp matchererror when using big files (over 400kb in my templates). It happens insideskeletor--evaluate-elisp-exprs-in-stringfunction. I've googled a little bit and it seems people usually solve this problem (which probably caused by emacs' regexp engine, details) by simplifying regexp, but I don't see ways to do it in this case. So I've added:no-eval-embedded-elisp?as per-template parameter to disable it for some specific projects. What are your thoughts on this issue?p.s. Thanks for great project!