Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger pipeline test + eslint errors fixes #3

Merged
merged 3 commits into from
Mar 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/lint-backend.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
name: Lint Backend

on: pull_request
on:
pull_request:
paths:
- "backend/**"

env:
PYTHON_VERSION: "3.11"
Expand Down
12 changes: 9 additions & 3 deletions .github/workflows/lint-frontend.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
name: Lint Frontend

on: pull_request
on:
pull_request:
paths:
- "frontend/**"

env:
NODE_VERSION: "20.11.x"

jobs:
lint-frontend:
Expand All @@ -12,10 +18,10 @@ jobs:
- name: Checkout to git repository
uses: actions/checkout@v2

- name: Setup node.js
- name: Setup node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v2
with:
node-version: 20.11.x
node-version: ${{ env.NODE_VERSION }}
cache: "npm"
cache-dependency-path: ./frontend/package-lock.json

Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/test-backend.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
name: Test Backend

on: pull_request
on:
pull_request:
paths:
- "backend/**"

env:
PYTHON_VERSION: "3.11"
Expand Down
12 changes: 9 additions & 3 deletions .github/workflows/test-frontend.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
name: Test Frontend

on: pull_request
on:
pull_request:
paths:
- "frontend/**"

env:
NODE_VERSION: "20.11.x"

jobs:
test-frontend:
Expand All @@ -12,10 +18,10 @@ jobs:
- name: Checkout to git repository
uses: actions/checkout@v2

- name: Setup node.js
- name: Setup node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v2
with:
node-version: 20.11.x
node-version: ${{ env.NODE_VERSION }}
cache: "npm"
cache-dependency-path: ./frontend/package-lock.json

Expand Down
1 change: 1 addition & 0 deletions frontend/components/chapter/SelectButton.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<option
v-for="chapter in chapters"
:value="{ id: chapter.id, number: chapter.chapter_number }"
:key="chapter.id"
>
Capítulo <span>{{ chapter.chapter_number }}</span>
</option>
Expand Down
2 changes: 1 addition & 1 deletion frontend/components/manwha/ChapterList.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<v-row>
<v-col v-for="chapter in manwha.chapters" cols="12" sm="6" md="4">
<v-col v-for="chapter in manwha.chapters" :key="chapter.id" cols="12" sm="6" md="4">
<v-row class="chapter">
<ChapterAccessButton
:chapterId="chapter.id"
Expand Down
2 changes: 1 addition & 1 deletion frontend/components/manwha/CompleteSummary.vue
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<img :title="manwha.name" :src="manwha.thumbnail" class="thumbnail" />
</v-col>
<v-col cols="12" md="8" class="content">
<div v-for="content in contents">
<div v-for="content in contents" :key="content['description']">
<ManwhaSummaryContent
:contentTitle="content['title']"
:contentDescription="manwha[content['description']]"
Expand Down
36 changes: 0 additions & 36 deletions frontend/components/ui/AppButtonList.vue

This file was deleted.

1 change: 1 addition & 0 deletions frontend/components/ui/SearchBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
<li
class="suggestion"
v-for="manwha in highlightedResults"
:key="manwha.manwha_id"
@click="navigateToManwha(manwha.manwha_id, manwha.manwha_name)"
>
<div class="pl-3 py-1">
Expand Down
1 change: 1 addition & 0 deletions frontend/composables/debounce.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// eslint-disable-next-line no-unused-vars
export function debounce(fn: Function, wait: number): (...args: any[]) => void {
let timer: NodeJS.Timeout;

Expand Down
4 changes: 2 additions & 2 deletions frontend/pages/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</v-col>
</v-row>
<v-row>
<v-col v-for="manwha in manwhas" cols="6" lg="3" md="4">
<v-col v-for="manwha in manwhas" :key="manwha.manwha_id" cols="6" lg="3" md="4">
<ManwhaUpdatesItem :manwha="manwha" />
</v-col>
</v-row>
Expand All @@ -21,7 +21,7 @@
<h2><v-icon icon="mdi-fire"></v-icon>Em Alta</h2>
</v-col>
</v-row>
<v-row v-for="manwha in manwhas">
<v-row v-for="manwha in manwhas" :key="manwha.manwha_id">
<ManwhaPopularItem :manwha="manwha" />
</v-row>
</v-col>
Expand Down
7 changes: 6 additions & 1 deletion frontend/pages/manwha/[manwha]/[chapter]/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@
/>
</v-col>
</v-row>
<v-row v-for="page in chapterData.pages" no-gutters class="reading-content text-center">
<v-row
v-for="page in chapterData.pages"
:key="page.url"
no-gutters
class="reading-content text-center"
>
<v-col>
<img :src="page.url" />
</v-col>
Expand Down
Loading