Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Collection and segment creation in single Tx. #2928

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[ENH] Collection and segment creation in single Tx. #2928

wants to merge 6 commits into from

Conversation

rohitcpbot
Copy link
Contributor

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Earlier, a collection and its segments were created as two different transactions. Failure scenarios could result in undesired state. This PR addresses it, and creates collection and segments together in a single transaction.
    • Changes are made at the implementation of the create_collection api and all layers below it, namely local sysdb, distributed sysdb, grpc implementation of sysdb, and the data layer.
    • Changes do not include the implementation for delete_collection(). This will be added after this PR merges.

Test plan

How are these changes tested?
Existing tests were modified to reflect the changes. New tests were added as welll.

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust, make test for golang.

Documentation Changes

None

@rohitcpbot
Collection and segment creation in 1 Tx.
f30d2be 
Added ability to create Collection and its associated segments
atomically in a in a single transaction to avoid partial failure
scenarios.

Added test case for coordinator/apis

Follow up work includes -
- Handling atomic deletes.
- More test cases.
@rohitcpbot
Add changes on the python side.
ed7b992
@rohitcpbot
Generated files from proto changes.
6acab40
@rohitcpbot
Cleanup. Removing debugging statements.
36dbbe9
@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@tazarov
Copy link
Contributor

tazarov commented Oct 10, 2024

Closes #2104

HammadB
HammadB reviewed Oct 10, 2024
View reviewed changes
chromadb/api/segment.py

# Get the segment related information for the collection.
# NOTE: Below call does not actually create segments in sysdb.
# TODO: Move this call out of the manager or change name.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just change the name - I agree its confusing. Its just creating the data objects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB left review comments

@atroyn atroyn Awaiting requested review from atroyn

@sanketkedia sanketkedia Awaiting requested review from sanketkedia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohitcpbot @tazarov @HammadB