[ENH]: LangchainJS Embedding Function

[tazarov]

Description of changes

Addresses an issue raised as part of #2129

Summarize the changes made by this PR.

• New functionality
  • New LangchainJS EF that allows Chroma users to take advantage of LC Embeddings and vice versa akin to chromadb/utils/embedding_functions/chroma_langchain_embedding_function.py

Test plan

How are these changes tested?

• Tests pass locally with yarn test for js

Documentation Changes

Added the new EF to embeddings integrations

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[tazarov]

• [ENH]: LangchainJS Embedding Function #2945 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tazarov and the rest of your teammates on Graphite

[codetheweb]

curious why this option is needed now?

[tazarov]

that's JS weirdness for you. We have circular import here chroma -> langchain-chroma -> chroma, so when the tests run, unless ESM modules (which is enabled with the --experimenta-vm-modules) are specified, we get an error from langchain-chroma that chromadb is not installed.

[codetheweb]

hmm I don't think --experimental-vm-modules is related to esm, do you have a link to the docs? and if there's a circular import is that something users will run into?

[tazarov]

here's the official Jest info on the use of the flag with ESM modules - https://jestjs.io/docs/ecmascript-modules

[codetheweb]

oh I see, jest itself switches modes if the flag is enabled
will users run into this or is this limited to our tests?

[tazarov]

My experiments showed that a third party project importing both LC and Chroma will not need to add the flag. However the test was a simple vanilla JS script, let me test with jest itself.