Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: fix(vacuum): correctly state that vacuum was released in 0.5.6 not 0.6 (fixes #2956) #2964

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Benzhaomin
Copy link

Description of changes

Change a single warning to correctly state the version where vacuum was introduced.

Test plan

No test needed this is only a string in a warning that is not tested.

Documentation Changes

Docstring updated, no change needed in other docs.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Benzhaomin Benzhaomin changed the title fix(vacuum): correctly state that vacuum was released in 0.5.6 not 0.6 (fixes #2956) [DOC] fix(vacuum): correctly state that vacuum was released in 0.5.6 not 0.6 (fixes #2956) Oct 17, 2024
@Benzhaomin Benzhaomin changed the title [DOC] fix(vacuum): correctly state that vacuum was released in 0.5.6 not 0.6 (fixes #2956) [Bug] fix(vacuum): correctly state that vacuum was released in 0.5.6 not 0.6 (fixes #2956) Oct 17, 2024
@Benzhaomin Benzhaomin changed the title [Bug] fix(vacuum): correctly state that vacuum was released in 0.5.6 not 0.6 (fixes #2956) [Bug]: fix(vacuum): correctly state that vacuum was released in 0.5.6 not 0.6 (fixes #2956) Oct 17, 2024
@tazarov
Copy link
Contributor

tazarov commented Oct 20, 2024

@Benzhaomin, you need to make some sort of a change on your code and push to make the PR title check pass. I suggest you rebase off the latest main and force push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants