Cucumber 2.4.0 support #17
Conversation
|
Apologies, now I've seen I wasn't running all tests. Hoping to get back with full code |
|
Related to #8 |
|
Another thing, my development environment is with ruby 2.4.1, so if you update travis config adding new ruby versions should run successfully |
|
Thank you for the pull request, and sorry for the long response! |
| @@ -9,7 +9,8 @@ namespace :generate do | |||
|
|
|||
| task :cucumber do | |||
| cucumber = "#{Gem.loaded_specs['cucumber'].gem_dir}/bin/cucumber" | |||
| run_ruby_acceptance "-rci/reporter/rake/cucumber_loader -S #{cucumber} --format CI::Reporter::Cucumber acceptance/cucumber" | |||
| # run_ruby_acceptance "-rci/reporter/rake/cucumber_loader -S #{cucumber} --format CI::Reporter::Cucumber acceptance/cucumber" | |||
There was a problem hiding this comment.
Please do not commit commented-out code.
| @@ -9,7 +9,8 @@ namespace :generate do | |||
|
|
|||
| task :cucumber do | |||
| cucumber = "#{Gem.loaded_specs['cucumber'].gem_dir}/bin/cucumber" | |||
| run_ruby_acceptance "-rci/reporter/rake/cucumber_loader -S #{cucumber} --format CI::Reporter::Cucumber acceptance/cucumber" | |||
| # run_ruby_acceptance "-rci/reporter/rake/cucumber_loader -S #{cucumber} --format CI::Reporter::Cucumber acceptance/cucumber" | |||
| run_ruby_acceptance "-rci/reporter/rake/cucumber_loader -S #{cucumber} --format CI::Reporter::Cucumber" | |||
There was a problem hiding this comment.
Instead of moving the directory, I'd rather add -r acceptance/cucumber/step_definitions/development_steps.rb to this command.
| @@ -17,7 +17,7 @@ Gem::Specification.new do |spec| | |||
| spec.test_files = spec.files.grep(%r{^(test|spec|features|acceptance)/}) | |||
| spec.require_paths = ["lib"] | |||
|
|
|||
| spec.add_dependency "cucumber", "~> 1.3.3" | |||
| spec.add_dependency "cucumber", "~> 2.4.0" | |||
There was a problem hiding this comment.
There's no need to be as drastic with the change here. It appears that ">= 1.3.3", "< 3.0.0" should be fine.
|
Don't worry. I've included your changes. |
|
@shepmaster Long time ago request. Could you review is still is pending something? thanks, |
Just modifying gemspec to use cucumber ~> 2.4.0 instead of ~> 1.3.3
Running unit_spec tests finishes all examples without failures.
Anything else needed ? Am I missing something?
Thanks,