Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Save time for build-clang workflow #2791

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Trung-DV
Copy link
Contributor

@Trung-DV Trung-DV commented Aug 11, 2024

Description

Save time for https://github.com/cilium/tetragon/actions/workflows/build-clang-image.yaml, from minutes to seconds
image

Changelog

@Trung-DV Trung-DV requested a review from a team as a code owner August 11, 2024 16:02
Copy link

netlify bot commented Aug 11, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit d273b4d
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/66b8e1468d180a0008702490
😎 Deploy Preview https://deploy-preview-2791--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Trung-DV <TrungDV.PMB@gmail.com>
@Trung-DV Trung-DV force-pushed the pr/Trung-DV/build-multi-platform-images branch from a2c5fc4 to d273b4d Compare August 11, 2024 16:05
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed but as far as I understand, we now we no longer build a multi-platform image locally with this, only the amd64 (and maybe a labeled arm64 image with the amd64 content). Maybe there's a way to optimize this but just FYI we rarely trigger this build.

on:
push:
branches:
- main
- v*
paths:
- 'Dockerfile.clang'
pull_request:
paths:
- 'Dockerfile.clang'
- '.github/workflows/build-clang-image.yaml'

@mtardy mtardy added the release-note/ci This PR makes changes to the CI. label Aug 12, 2024
@Trung-DV
Copy link
Contributor Author

.github/workflows/build-clang-image.yaml

I see that every PR relates to update Golang versions which modify .github/workflows/build-clang-image.yaml will trigger this workflow.

Or, may be we can use https://docs.docker.com/reference/dockerfile/#onbuild 🤔 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants