Remove tetragon_msg_op_total metric #2856
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdanis
added
area/metrics
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tetragon_msg_op_total was counting events per opcode in the ring buffer queue. It wasn't particularly useful, as there are other metrics exposing similar numbers: * tetragon_bpf_missed_events_total counting missed events per opcode in BPF * tetragon_observer_ringbuf_queue_events_received_total counting total events received in the ring buffer queue * tetragon_events_total counting events per event type in grpc If needed, in the future we can add opcode label to metrics counting events in the observer: * tetragon_observer_ringbuf_events_received_total * tetragon_observer_ringbuf_queue_events_received_total * tetragon_observer_ringbuf_queue_events_lost_total We could also add a metric counting all events (not only missed) per opcode in BPF. However, it's unclear if they could be useful - ringbuffer and events queue shouldn't discriminate different types of events, so having total counts of successful and missed events at each stage should be enough to troubleshoot capacity issues. There is still a per event type counter at the last stage, for monitoring overall data volume. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
force-pushed
the
pr/lambdanis/observer-metrics-op
branch
from
74212a7
to
7791130
Compare
|
Converting to draft as I need to rethink how these metrics should be used. |
kevsecurity
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tetragon_msg_op_total was counting events per opcode in the ring buffer queue. It wasn't particularly useful, as there are other metrics exposing similar numbers:
If needed, in the future we can add opcode label to metrics counting events in the observer:
We could also add a metric counting all events (not only missed) per opcode in BPF. However, it's unclear if they could be useful - ringbuffer and events queue shouldn't discriminate different types of events, so having total counts of successful and missed events at each stage should be enough to troubleshoot capacity issues. There is still a per event type counter at the last stage, for monitoring overall data volume.