monocle3, scala3 upgrade #336

inanme · 2023-07-25T11:42:20Z

I guess it's customary to create a PR for Scala3 & Monocle3 upgrades. This PR removes all deprecated Monocle API usages.

inanme · 2023-07-25T11:43:55Z

optics/src/main/scala/io/circe/optics/JsonNumberOptics.scala

@@ -39,6 +39,6 @@ trait JsonNumberOptics {
    )
 }

-final object JsonNumberOptics extends JsonNumberOptics {


stop scala3 compiler warning, also applies to other occurrences.

inanme · 2023-07-25T13:06:41Z

@zmccoy @zarthross please let me what you think, thanks

zmccoy · 2023-07-26T22:01:13Z

Hi @inanme at first glance we'll want keep the Scala versions at the Build level such as : https://github.com/circe/circe/blob/series/0.14.x/build.sbt#L13. That will keep 2.12,2.13, and 3 in github action workflow yaml.

You'll probably want to rebase as well as there were some merges from a few weeks ago that added in the sbt-circe-org plugin which helps make things a bit cleaner.

inanme · 2023-07-27T15:44:12Z

@zmccoy I welcome the SBT changes. With regards to my changes, I had to drop scala212 as monocle3 does not support/ dropped 212. Let me know if this is an issue. My main motivation for this PR to get monocle3 upgraded, scala3 nice to have.

inanme · 2023-07-27T15:45:01Z

You'll probably want to rebase

rebase done.

GreyPlane

just few minor style issues, looks good!

GreyPlane · 2023-07-31T15:01:00Z

optics/src/main/scala/io/circe/optics/JsonPath.scala


  final def applyDynamic(field: String)(index: Int): JsonTraversalPath = selectDynamic(field).index(index)

  final def apply(i: Int): JsonTraversalPath = index(i)

  final def index(i: Int): JsonTraversalPath =
-    JsonTraversalPath(json.composePrism(jsonArray).composeOptional(Index.index(i)))
+    JsonTraversalPath(json.andThen(jsonArray).andThen(Index.index(i)(Index.vectorIndex[Json])))


It could be more stylish if written in Index.index[Vector[Json], Int, Json](i) IMO

thanks, agreed, 3e2abe3

also 844a837

GreyPlane · 2023-07-31T15:01:28Z

optics/src/main/scala/io/circe/optics/JsonPath.scala


  final def filterByIndex(p: Int => Boolean): JsonTraversalPath =
-    JsonTraversalPath(arr.composeTraversal(FilterIndex.filterIndex(p)))
+    JsonTraversalPath(arr.andThen(FilterIndex.filterIndex(p)(FilterIndex.vectorFilterIndex[Json])))


same reason as above, written as FilterIndex.filterIndex[Vector[Json], Int, Json](p)

thanks, agreed, 3e2abe3

also 844a837

zmccoy · 2023-08-02T21:13:06Z

@inanme The dropping of 2.12 for monocle3 is not an issue in that case, I didn't know they dropped 2.12. We're going to want to think about branching strategy and version numbers expectations as this is bin incompat change.

zmccoy · 2023-08-02T21:16:49Z

The failures right now are expected as mima is showing that things are not bin compat. We can solve this once we figure out our branch / version strategy for this then :)

GreyPlane · 2023-08-03T07:29:40Z

I didn't found any particular reason for Monocle to drop the support for Scala 2.12.x, Only because they're trying to reduce maintenance burden so decided to only support 2 major versions of Scala, I think we could ask them if it is possible to bring back it.

zarthross · 2023-08-03T13:32:47Z

I didn't found any particular reason for Monocle to drop the support for Scala 2.12.x, Only because they're trying to reduce maintenance burden so decided to only support 2 major versions of Scala, I think we could ask them if it is possible to bring back it.

Sorry we weren't more clear, we can drop scala 2.12.x just fine. The binary incompatibility we are concerned with this the update to monocle 3. We can't just release this change as 0.14.2 because even if the changes in circe optics are compatible, we would be forcing a binary incompatible version of monocle on all consumers of circe optics. We do need this upgraded, but we need to decide between the options for how to go forward:

We change the artifact name to circe-optics-monocle3 or similar and update the package names, so that we can release as version 0.14.2.

Pros: We can support monocle2 for longer
Cons: Confusion of artifact name change
Questions: what do we do when circe releases 0.15? Do we go back to circe-optics? Do we keep the long name

We publish this as 0.15.0

Pros: We indicate the bin-incompat nature of the change, we don't have to rename any artifacts or packages
Cons: We create a LOT of confusion about the compatibility between circe-optics and Circe core.

inanme · 2023-08-03T19:55:16Z

Would this configuration work in circe ecosystem? I setup projects like this using sbt-projectmatrix.
0.14.2 -> (scala212 -> monocle2) -> circe-optics / /BAU
0.14.2 -> (scala213 -> monocle2) -> circe-optics / /BAU
0.14.2 -> (scala213 -> monocle3) -> circe-optics-monocle3 // new artefact
0.14.2 -> (scala3 -> monocle3) -> circe-optics // new artefact

zarthross · 2023-08-09T21:27:42Z

@zmccoy and I discussed, and we think the best approach would be to use this naming scheme:

0.14.2 -> (scala212 -> monocle2) -> circe-optics
0.14.2 -> (scala213 -> monocle2) -> circe-optics
0.14.2 -> (scala213 -> monocle3) -> circe-optics-monocle_3 
0.14.2 -> (scala3   -> monocle3) -> circe-optics-monocle_3

We'll want to add something to the readme as well, to point users to this new artifact.

@GreyPlane How does this approach sound to you?

GreyPlane · 2023-08-10T04:02:04Z

Personally, I'd like to say continuously support for circe-optics(monocle2) seems to unnecessary since Monocle itself dropped the support already, so release to next major version looks fine to me, and even Circe itself's major release holds bin comp, but it's more like a bonus since semantic version doesn't enforce that, so even at some point one of the Circe's associated project doesn't keep it, this behavior should be expected with some extent.

But I don't hold very strong opinion about this, especially if there is real world needs for using circe-optics with monocle 2, I'm OK with the new artifact.

GreyPlane · 2023-08-31T10:05:27Z

@inanme I guess you have to exclude mima previous artifact for Scala 3 cross build as document says.

@zarthross and so, are we decided to release new artifact under a new name?

QuitHub · 2023-09-12T09:11:12Z

It would be really great to have this available!

zarthross · 2023-09-13T21:26:42Z

@GreyPlane, I think you have a persuasive argument. I'm ok with abandoning support for monocle 2, releasing a new version of circe-optics as 0.15 with monocle 3, and including in the readme a table with a note about the versioning and how it relates to circe-core. See https://github.com/circe/circe-generic-extras#versioning please use the same verbiage and structure for consistency.

joan38 · 2023-09-14T19:04:41Z

Hey, Thanks for the work here!
We are also blocked on this to upgrade to Scala 3.
Sounds like depending on the 2.13 package from Scala 3 is not working.

GreyPlane · 2023-09-15T02:26:43Z

@inanme Hi buddy, I am currently un-employed, so I can pick this up as I have bit more time to focus. If you like me to look more into this issue.

joan38 · 2023-09-18T14:52:40Z

ResolveException: Error downloading io.circe:circe-optics_3:0.14.1

Why is it trying to resolve itself?

joan38 · 2023-09-19T04:26:18Z

So I understand the current build is not going through because of MiMa.

Is there anything we can do to move forward? Sounds like we have a sizable amount of people volunteering. Is the issue technical or political here?

We have projects we need to move forward on Scala 3 depending on circe-optics. Can a maintainer step forward?

GreyPlane · 2023-09-19T05:41:24Z

@joan38 not any problem really, I think we have reach the consensus here and there isn't any hard technical issue, just have to finish the work.
I guess it's ok to pick this work into new branch and submit a new PR with respect to the original, you'd like to do it by yourself? or i can do it as i said before.

zarthross · 2023-09-20T21:47:48Z

Thanks for the work on this.

inanme commented Jul 25, 2023

View reviewed changes

monocle3, scala3 upgrade

4f2bd7a

inanme force-pushed the monocle2-scala3 branch from fe73179 to 4f2bd7a Compare July 27, 2023 15:40

GreyPlane approved these changes Jul 31, 2023

View reviewed changes

inanme added 2 commits July 31, 2023 19:59

set type parameters

3e2abe3

set type parameters functions in JsonTraversalPath

844a837

Merge remote-tracking branch 'origin/master' into monocle3

c758b85

zarthross mentioned this pull request Aug 9, 2023

Update snakeyaml to 2.1 circe/circe-yaml#383

Closed

GreyPlane mentioned this pull request Sep 19, 2023

Monocle 3 and Scala 3 support #347

Closed

zarthross mentioned this pull request Sep 20, 2023

Upgrade to Scala 3 and Monocle 3 #348

Merged

zarthross closed this Sep 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

monocle3, scala3 upgrade #336

monocle3, scala3 upgrade #336

inanme commented Jul 25, 2023 •

edited

Loading

inanme Jul 25, 2023

inanme commented Jul 25, 2023

zmccoy commented Jul 26, 2023

inanme commented Jul 27, 2023

inanme commented Jul 27, 2023 •

edited

Loading

GreyPlane left a comment

GreyPlane Jul 31, 2023

inanme Jul 31, 2023

inanme Aug 2, 2023

GreyPlane Jul 31, 2023

inanme Jul 31, 2023

inanme Aug 2, 2023

zmccoy commented Aug 2, 2023

zmccoy commented Aug 2, 2023

GreyPlane commented Aug 3, 2023

zarthross commented Aug 3, 2023

inanme commented Aug 3, 2023

zarthross commented Aug 9, 2023

GreyPlane commented Aug 10, 2023

GreyPlane commented Aug 31, 2023

QuitHub commented Sep 12, 2023

zarthross commented Sep 13, 2023

joan38 commented Sep 14, 2023 •

edited

Loading

GreyPlane commented Sep 15, 2023

joan38 commented Sep 18, 2023

joan38 commented Sep 19, 2023 •

edited

Loading

GreyPlane commented Sep 19, 2023

zarthross commented Sep 20, 2023

monocle3, scala3 upgrade #336

monocle3, scala3 upgrade #336

Conversation

inanme commented Jul 25, 2023 • edited Loading

inanme Jul 25, 2023

Choose a reason for hiding this comment

inanme commented Jul 25, 2023

zmccoy commented Jul 26, 2023

inanme commented Jul 27, 2023

inanme commented Jul 27, 2023 • edited Loading

GreyPlane left a comment

Choose a reason for hiding this comment

GreyPlane Jul 31, 2023

Choose a reason for hiding this comment

inanme Jul 31, 2023

Choose a reason for hiding this comment

inanme Aug 2, 2023

Choose a reason for hiding this comment

GreyPlane Jul 31, 2023

Choose a reason for hiding this comment

inanme Jul 31, 2023

Choose a reason for hiding this comment

inanme Aug 2, 2023

Choose a reason for hiding this comment

zmccoy commented Aug 2, 2023

zmccoy commented Aug 2, 2023

GreyPlane commented Aug 3, 2023

zarthross commented Aug 3, 2023

inanme commented Aug 3, 2023

zarthross commented Aug 9, 2023

GreyPlane commented Aug 10, 2023

GreyPlane commented Aug 31, 2023

QuitHub commented Sep 12, 2023

zarthross commented Sep 13, 2023

joan38 commented Sep 14, 2023 • edited Loading

GreyPlane commented Sep 15, 2023

joan38 commented Sep 18, 2023

joan38 commented Sep 19, 2023 • edited Loading

GreyPlane commented Sep 19, 2023

zarthross commented Sep 20, 2023

inanme commented Jul 25, 2023 •

edited

Loading

inanme commented Jul 27, 2023 •

edited

Loading

joan38 commented Sep 14, 2023 •

edited

Loading

joan38 commented Sep 19, 2023 •

edited

Loading