fix(sync): pull Malachite suffix-gap fix - #283
Conversation
|
Verified the scope of this bump against upstream before anything else, since consensus-dep pins deserve suspicion. The core claims all check out:
One thing I'd fix before merge: The Two smaller notes:
Also a practical heads-up given #282 is in flight: #214 currently has no assignee, and under the incoming PR gate this PR's author would need to be assigned to it. A maintainer assigning @huklaa to #214 would both reflect reality and keep this PR from tripping the new policy if it's reopened later. Scope, target, and upstream test all verified — with a minimal lockfile this is the right way to close #214. |
a7ec533 to
f07f99e
Compare
|
Hi @huklaa, thanks for putting this together and for the clear write-up linking back to #214 and #227 — the suffix-gap context is really helpful. We're going to close this for now. The malachite dependency is scheduled to receive a broader update as part of our upcoming v0.8 release, which will bring in the upstream suffix-gap fix (and several related changes) in one coordinated bump. Thanks again for the contribution! |
Fixes #214.
This updates the Malachite revision to include the upstream suffix-gap fix that addresses the remaining follower-sync deadlock path.
PR #227 only moved Arc to an earlier Malachite revision and explicitly did not include this suffix-gap fix, so this is a separate follow-up scope.
The updated Malachite revision preserves the requested suffix when a missing prefix is re-requested, preventing the follower from losing the suffix and getting stuck in a sync loop.
Validation:
cargo build -p arc-node-consensus --locked
targeted regression coverage is included upstream in Malachite commit 378b0e5