Ensure no temporary directories are left behind #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
reviewed
Aug 28, 2024
rabadin
force-pushed
the
cleanup-tmp-dir
branch
from
7e5891c
to
8047a24
Compare
rabadin
force-pushed
the
cleanup-tmp-dir
branch
from
8047a24
to
c3eeb21
Compare
rabadin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core problem is that base64 encoded strings can have slashes in them... so this would create intermediate directories that would be left behind. Using a different encoding for the temporary files solves this problem.
Fixes #5