Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TECH-156: Add support for external issuers #23

Merged
merged 3 commits into from
May 21, 2024

Conversation

TYRONEMICHAEL
Copy link
Contributor

@TYRONEMICHAEL TYRONEMICHAEL commented May 17, 2024

The PR adds support for adding an administrator when deploying the canister. The admin is able to add and remove issuers where an issuer is a principal that can issue credentials.

@TYRONEMICHAEL TYRONEMICHAEL merged commit a900a6f into develop May 21, 2024
4 checks passed
@TYRONEMICHAEL TYRONEMICHAEL deleted the TECH-156-add-support-external-issuers branch May 21, 2024 19:24
Copy link
Collaborator

@CallForSanity CallForSanity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

The only remark I have is that it could benefit from stable storage too. As it is right now authorized_issuers will be lost on canister upgrades. This should be done in a separate ticket/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants