TECH 292 - Remove SupportedTypes Constraint #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Slight refactor to credential module - Remove Credential Error - Catch error and return empty credential so the user inspects the JWT in order to see if the credential exists instead of seeing an error when presenting the credential
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…o TECH-292__update-icp-canister-support-civic-pass
…o TECH-292__update-icp-canister-support-civic-pass
CallForSanity
approved these changes
Aug 8, 2024
| ["alumniOf", { Claim: alumniOfClaim }] | ||
| ["tigoYhp9SpCDoCQmXGj2im5xa3mnjR1zuXrpCJ5ZRmi", { Boolean: true }], | ||
| ["Status", { Text: "ACTIVE" }], | ||
| ["expirationDate", { Number: 1000 + 365 * 24 * 60 * 60 * 1000 }] |
There was a problem hiding this comment.
I would expect something relative here, e.g. currentData + constant but I guess this is just for demoing anyway?
TYRONEMICHAEL
changed the title
dankelleher
reviewed
Aug 12, 2024
dankelleher
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TECH-292 - Update civic canister to support civic pass