TECH-292 - Show the credential when presented #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TYRONEMICHAEL
commented
Sep 3, 2024
•
TYRONEMICHAEL
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pedroapfilho
reviewed
Sep 3, 2024
| <img src="/logo2.svg" alt="DFINITY logo" className="mx-auto mb-8 w-32" /> | ||
|
|
||
| {principal ? ( | ||
| <div className="flex flex-col items-center justify-center"> | ||
| <h1 className="text-2xl font-bold text-center mb-4">Welcome to the ICP Relying Canister</h1> | ||
| <p className="text-center mb-6">Logged in as <span className="font-mono bg-gray-100 p-1 rounded">{principal?.toText()}</span></p> | ||
| {credentialCheckResponse && ( | ||
| <div className="mb-6 "> |
There was a problem hiding this comment.
should maybe be a gap on the parent?
There was a problem hiding this comment.
Not sure what you mean here.
| {credentialCheckResponse && ( | ||
| <div className="mb-6 "> | ||
| <p className="text-sm text-gray-600">Response:</p> | ||
| <p className="font-mono text-sm bg-gray-100 p-8 rounded">{JSON.stringify(credentialCheckResponse.credential, undefined, 2)}</p> |
There was a problem hiding this comment.
instead of this p, use <pre><code> to create it
|
Approval via Slack from Pedro. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.