Normalize address upon transaction pool inspection (identity-com#35)

* Normalize address upon tx pool inspection * Update dependencies to fix issues reported by NPM audit
civicteam · Mar 26, 2019 · d8baf4c · d8baf4c
1 parent efe7192
commit d8baf4c
Show file tree

Hide file tree

Showing 6 changed files with 124 additions and 70 deletions.
diff --git a/AUDIT.md b/AUDIT.md
@@ -12,5 +12,3 @@ Whenever you whitelist a specific advisory it is required to refer it here and j
 | #    | Level | Module | Title | Explanation |
 |------|-------|---------|------|-------------|
 | 782 | Moderate | lodash | Prototype Pollution | Dev dependency, path: smart-contracts: > truffle-artifactor > lodash |
-| 755 | High | handlebars | Prototype Pollution | Dev dependency, path: nyc > istanbul-reports > handlebars |
-
diff --git a/audit-ci.json b/audit-ci.json
@@ -2,6 +2,6 @@
   "low": true,
   "package-manager": "auto",
   "report": true,
-  "advisories": [755, 782],
+  "advisories": [782],
   "whitelist": []
 }
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -74,7 +74,7 @@
     "mocha": "^4.1.0",
     "node-fetch": "^2.3.0",
     "npm-run-all": "^4.1.5",
-    "nyc": "^13.2.0",
+    "nyc": "^13.3.0",
     "prettier": "1.10.2",
     "proxyquire": "^2.1.0",
     "sinon": "^6.0.1",

diff --git a/src/support/nonce/accountInspector.js b/src/support/nonce/accountInspector.js
@@ -1,3 +1,4 @@
+const ethUtil = require('ethereumjs-util');
 const util = require('util');
 
 module.exports = class AccountInspector {
@@ -46,9 +47,10 @@ module.exports = class AccountInspector {
           }
           return reject(error);
         }
+        const checksummedAddress = ethUtil.toChecksumAddress(address);
         return resolve({
-          pending: result.pending[address] || {},
-          queued: result.queued[address] || {}
+          pending: result.pending[checksummedAddress] || {},
+          queued: result.queued[checksummedAddress] || {}
         });
       });
     });