Feat/update #14
Open
Feat/update #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13archit
requested changes
Sep 18, 2024
versions.tf
Outdated
| @@ -1,12 +1,12 @@ | |||
| terraform { | |||
| required_version = ">= 1.3.6" | |||
| required_version = ">= 1.9.0" | |||
| @@ -249,4 +493,90 @@ variable "integration_subnet_id" { | |||
| type = string | |||
| default = null | |||
| description = "The resource ID of the subnet" | |||
| } | |||
|
|
|||
| variable "app_insights_workspace_id" { | |||
There was a problem hiding this comment.
Where is description?
Please add in all and also please follow the following format:-
type = ""
default = ""
description = ""
.github/workflows/tf-checks.yml
Outdated
| pull_request: | ||
| workflow_dispatch: | ||
| complete-linux-example: | ||
| uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@1.2.8 |
There was a problem hiding this comment.
Please use master branch. Also correct in all other workflows.
| module "resource_group" { | ||
| source = "clouddrove/resource-group/azure" | ||
| version = "1.0.2" | ||
|
|
There was a problem hiding this comment.
remove extra space, also check other also and remove.
d4kverma
reviewed
Sep 18, 2024
.github/workflows/auto_assignee.yml
Outdated
| workflow_dispatch: | ||
| jobs: | ||
| assignee: | ||
| uses: clouddrove/github-shared-workflows/.github/workflows/auto_assignee.yml@1.2.8 |
There was a problem hiding this comment.
1.28 instead of this use branch
d4kverma
reviewed
Sep 18, 2024
.github/workflows/automerge.yml
Outdated
| pull_request: | ||
| jobs: | ||
| auto-merge: | ||
| uses: clouddrove/github-shared-workflows/.github/workflows/auto_merge.yml@1.2.8 |
There was a problem hiding this comment.
1.28 instead of this use branch
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why