Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operators can suppress warnings for invalid drains (Windows) #425

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

acrmp
Copy link
Member

@acrmp acrmp commented Nov 8, 2023

Description

In #422 we made warnings for invalid syslog drains configurable but neglected to add the same property to the loggr-syslog-agent-windows job.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack

In b64e1ee we made warnings for invalid syslog drains configurable but
neglected to add the same property to the loggr-syslog-agent-windows
job.
@acrmp acrmp requested a review from a team as a code owner November 8, 2023 01:42
@rroberts2222 rroberts2222 merged commit b8b0459 into main Nov 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants