Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove __v1_type tag when forwarding metrics to otel collector #441

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

acrmp
Copy link
Member

@acrmp acrmp commented Dec 4, 2023

Description

  • Metrics that were received initially as v1 metrics include a __v1_type tag to indicate the type of v1 metric that was emitted.
  • This causes issues for the prometheus exporter as: 'Label names beginning with __ (two "_") are reserved for internal use.' https://prometheus.io/docs/concepts/data_model/
  • Remove the __v1_type tag during the conversion so that these metrics will be acceptable to prometheus exporters.

Fixes:

 "__v1_type" is not a valid label name for metric

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack

- Metrics that were received initially as v1 metrics include a __v1_type
  tag to indicate the type of v1 metric that was emitted.
- This causes issues for the prometheus exporter as:
  'Label names beginning with __ (two "_") are reserved for internal use.'
  https://prometheus.io/docs/concepts/data_model/
- Remove the __v1_type tag during the conversion so that these metrics
  will be acceptable to prometheus exporters.

Fixes:

  "__v1_type" is not a valid label name for metric

Signed-off-by: Rebecca Roberts <robertsre@vmware.com>
@acrmp acrmp requested a review from a team as a code owner December 4, 2023 22:16
@acrmp acrmp merged commit b51fa0c into main Dec 4, 2023
7 checks passed
@acrmp acrmp deleted the remove-v1-type-tag branch December 4, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants