Skip to content

chore: Revert table-role and async-store move into component-toolkit (#242) - #250

Draft
gethinwebster wants to merge 1 commit into
mainfrom
revert-table-role-async-store-242
Draft

chore: Revert table-role and async-store move into component-toolkit (#242)#250
gethinwebster wants to merge 1 commit into
mainfrom
revert-table-role-async-store-242

Conversation

@gethinwebster

Copy link
Copy Markdown
Member

Description

Removes the table-role and async-store internal primitives from component-toolkit (src/internal/table-role/, src/internal/async-store/, their package.json subpath exports, and the tsconfig.unit.json lib entry).

These primitives were duplicated here so a separate BasicTable repository could consume them from the toolkit. BasicTable now lives in cloudscape-design/components (src/beta/basic-table-0.1/) and imports these primitives directly from that repo, so the toolkit copies are unused.

Nothing in component-toolkit imports these modules, and the copies in cloudscape-design/components are unaffected.

Verification

  • npm run build — passes
  • npm run test:unit — 49 suites / 460 tests pass

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (744ad19) to head (3a42296).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   98.09%   99.02%   +0.93%     
==========================================
  Files          56       48       -8     
  Lines        1787     1337     -450     
  Branches      517      369     -148     
==========================================
- Hits         1753     1324     -429     
+ Misses         33       12      -21     
  Partials        1        1              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant