chore: Revert table-role and async-store move into component-toolkit (#242) - #250
Draft
gethinwebster wants to merge 1 commit into
Draft
chore: Revert table-role and async-store move into component-toolkit (#242)#250gethinwebster wants to merge 1 commit into
gethinwebster wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 98.09% 99.02% +0.93%
==========================================
Files 56 48 -8
Lines 1787 1337 -450
Branches 517 369 -148
==========================================
- Hits 1753 1324 -429
+ Misses 33 12 -21
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
table-roleandasync-storeinternal primitives from component-toolkit (src/internal/table-role/,src/internal/async-store/, theirpackage.jsonsubpath exports, and thetsconfig.unit.jsonlibentry).These primitives were duplicated here so a separate BasicTable repository could consume them from the toolkit. BasicTable now lives in
cloudscape-design/components(src/beta/basic-table-0.1/) and imports these primitives directly from that repo, so the toolkit copies are unused.Nothing in component-toolkit imports these modules, and the copies in
cloudscape-design/componentsare unaffected.Verification
npm run build— passesnpm run test:unit— 49 suites / 460 tests pass