refactor: optimize autosuggest filterOptions performance - #4206
Open
TrevorBurnham wants to merge 1 commit into
Open
refactor: optimize autosuggest filterOptions performance#4206TrevorBurnham wants to merge 1 commit into
TrevorBurnham wants to merge 1 commit into
Conversation
pan-kot
requested changes
Jul 10, 2026
pan-kot
left a comment
pan-kot
left a comment
Member
There was a problem hiding this comment.
The PR needs a conflict resolution with main.
TrevorBurnham
force-pushed
the
refactor-autosuggest-filteroptions
branch
from
July 11, 2026 01:15
01ac133 to
6c601fa
Compare
Contributor
Author
Done! |
pan-kot
approved these changes
Jul 13, 2026
pan-kot
enabled auto-merge
July 13, 2026 04:49
pan-kot
requested changes
Jul 13, 2026
pan-kot
left a comment
pan-kot
left a comment
Member
There was a problem hiding this comment.
@TrevorBurnham please fix failing tests
auto-merge was automatically disabled
July 13, 2026 11:42
Head branch was pushed to by a user without write access
TrevorBurnham
force-pushed
the
refactor-autosuggest-filteroptions
branch
from
July 13, 2026 11:42
6c601fa to
30929cd
Compare
Contributor
Author
Done! |
pan-kot
self-requested a review
August 25, 2026 07:53
TrevorBurnham
force-pushed
the
refactor-autosuggest-filteroptions
branch
from
August 26, 2026 15:08
4588c9c to
5c7110d
Compare
- Move searchableFields and searchableTagFields arrays to module scope to avoid recreating them on every matchSingleOption call - Move toLowerCase() call outside the filter loop to avoid repeated string operations - Replace indexOf() !== -1 with includes() for cleaner, slightly faster string matching Benchmarks show 10-25% improvement for typical filtering scenarios.
TrevorBurnham
force-pushed
the
refactor-autosuggest-filteroptions
branch
from
August 28, 2026 14:41
ee4401c to
9f3d9af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the
filterOptionsutility insrc/autosuggest/utils/utils.tsby applying three micro-optimizations:searchableFieldsandsearchableTagFieldsarrays outside thematchSingleOptionfunction to avoid recreating them on every calltoLowerCase()outside the filter loop: The search text is now lowercased once infilterOptionsrather than on everymatchSingleOptioncallindexOf() !== -1withincludes(): More idiomatic and slightly faster for substring matchingThe
filterOptionsfunction is called whenever:filteringType="auto")This is a hot path during user interaction, as filtering runs on every keystroke.
Micro-benchmarks show 10-25% improvement for typical filtering scenarios
How has this been tested?
Existing tests provide extensive coverage for this functionality.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.