Skip to content

fix: propagate one-theme class to remaining portaled content - #4934

Open
Harsh-Anand-Singh wants to merge 1 commit into
mainfrom
fix-one-theme-portal-propagation-gaps
Open

fix: propagate one-theme class to remaining portaled content#4934
Harsh-Anand-Singh wants to merge 1 commit into
mainfrom
fix-one-theme-portal-propagation-gaps

Conversation

@Harsh-Anand-Singh

@Harsh-Anand-Singh Harsh-Anand-Singh commented Aug 25, 2026

Copy link
Copy Markdown
Member

Problem

#4599 added propagation of the awsui-one-theme class to portaled content, but some portal render points still did not receive it. When One Theme is activated on an ancestor instead of on body, those overlays render without the theme.

What this PR does

Propagates awsui-one-theme to the remaining affected portal wrappers so their overlays keep One Theme styling when rendered through document.body. The affected components are Modal, Tooltip, internal Tooltip, Drawer, AnnotationContext annotations, FeaturePrompt, the drag-handle portal overlay, and the SortableArea drag overlay.

Testing

Added focused unit coverage for each affected portal path plus the SSR placeholder check. Verified with targeted Jest suites, npm run build, and npm run lint .

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.66%. Comparing base (189b5ce) to head (91dceda).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4934   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files         958      958           
  Lines       31317    31328   +11     
  Branches    11565    11568    +3     
=======================================
+ Hits        30585    30596   +11     
+ Misses        725      686   -39     
- Partials        7       46   +39     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mxschll
mxschll removed their request for review August 26, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants