fix: propagate one-theme class to remaining portaled content - #4934
Open
Harsh-Anand-Singh wants to merge 1 commit into
Open
fix: propagate one-theme class to remaining portaled content#4934Harsh-Anand-Singh wants to merge 1 commit into
Harsh-Anand-Singh wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4934 +/- ##
=======================================
Coverage 97.66% 97.66%
=======================================
Files 958 958
Lines 31317 31328 +11
Branches 11565 11568 +3
=======================================
+ Hits 30585 30596 +11
+ Misses 725 686 -39
- Partials 7 46 +39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Harsh-Anand-Singh
force-pushed
the
fix-one-theme-portal-propagation-gaps
branch
from
August 25, 2026 20:29
ec64013 to
9068eb3
Compare
Harsh-Anand-Singh
force-pushed
the
fix-one-theme-portal-propagation-gaps
branch
2 times, most recently
from
August 25, 2026 21:06
230c8b1 to
90a669c
Compare
Harsh-Anand-Singh
force-pushed
the
fix-one-theme-portal-propagation-gaps
branch
from
August 25, 2026 21:33
90a669c to
cdcb249
Compare
Harsh-Anand-Singh
temporarily deployed
to
allure-report
August 25, 2026 21:56 — with
GitHub Actions
Inactive
Harsh-Anand-Singh
force-pushed
the
fix-one-theme-portal-propagation-gaps
branch
from
August 26, 2026 07:58
cdcb249 to
91dceda
Compare
Harsh-Anand-Singh
marked this pull request as ready for review
August 26, 2026 09:17
Harsh-Anand-Singh
enabled auto-merge
August 26, 2026 09:17
mxschll
removed their request for review
August 26, 2026 12:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#4599 added propagation of the awsui-one-theme class to portaled content, but some portal render points still did not receive it. When One Theme is activated on an ancestor instead of on body, those overlays render without the theme.
What this PR does
Propagates awsui-one-theme to the remaining affected portal wrappers so their overlays keep One Theme styling when rendered through document.body. The affected components are Modal, Tooltip, internal Tooltip, Drawer, AnnotationContext annotations, FeaturePrompt, the drag-handle portal overlay, and the SortableArea drag overlay.
Testing
Added focused unit coverage for each affected portal path plus the SSR placeholder check. Verified with targeted Jest suites, npm run build, and npm run lint .