Skip to content

refactor: apply usePortalModeClasses to remaining portaled components - #4942

Open
Harsh-Anand-Singh wants to merge 2 commits into
mainfrom
refactor-portal-mode-classes
Open

refactor: apply usePortalModeClasses to remaining portaled components#4942
Harsh-Anand-Singh wants to merge 2 commits into
mainfrom
refactor-portal-mode-classes

Conversation

@Harsh-Anand-Singh

Copy link
Copy Markdown
Member

Description

This draft PR applies usePortalModeClasses to the remaining portaled components so portal-mode styling follows the same shared pattern across the codebase.

Some components already preserve portal-mode classes correctly when rendering through portals, while others still rely on component-specific handling. This change aligns those implementations and closes the remaining propagation gaps.

Changes

  • apply usePortalModeClasses to remaining portaled components
  • replace inconsistent component-level portal-mode handling with the shared hook
  • add or update tests covering portal-mode class propagation

Why

This keeps portal behavior consistent across components and reduces the chance of styling mismatches when content is rendered outside the normal DOM tree.

Testing

  • updated relevant tests for affected portaled components
  • verified portal-mode classes propagate as expected in portal-rendered content

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.66%. Comparing base (09c3c60) to head (c8c3367).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4942   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files         959      959           
  Lines       31342    31367   +25     
  Branches    11577    11584    +7     
=======================================
+ Hits        30610    30635   +25     
+ Misses        725      686   -39     
- Partials        7       46   +39     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant