refactor: apply usePortalModeClasses to remaining portaled components - #4942
Open
Harsh-Anand-Singh wants to merge 2 commits into
Open
refactor: apply usePortalModeClasses to remaining portaled components#4942Harsh-Anand-Singh wants to merge 2 commits into
Harsh-Anand-Singh wants to merge 2 commits into
Conversation
Harsh-Anand-Singh
force-pushed
the
refactor-portal-mode-classes
branch
from
August 27, 2026 15:39
cdcb249 to
ccc5521
Compare
Harsh-Anand-Singh
force-pushed
the
refactor-portal-mode-classes
branch
from
August 28, 2026 09:59
74006af to
696836a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4942 +/- ##
=======================================
Coverage 97.66% 97.66%
=======================================
Files 959 959
Lines 31342 31367 +25
Branches 11577 11584 +7
=======================================
+ Hits 30610 30635 +25
+ Misses 725 686 -39
- Partials 7 46 +39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Harsh-Anand-Singh
force-pushed
the
refactor-portal-mode-classes
branch
from
August 28, 2026 13:41
4da986f to
a741939
Compare
Harsh-Anand-Singh
force-pushed
the
refactor-portal-mode-classes
branch
from
August 28, 2026 14:51
b757851 to
c8c3367
Compare
Harsh-Anand-Singh
marked this pull request as ready for review
August 28, 2026 15:18
Harsh-Anand-Singh
enabled auto-merge
August 28, 2026 15:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This draft PR applies
usePortalModeClassesto the remaining portaled components so portal-mode styling follows the same shared pattern across the codebase.Some components already preserve portal-mode classes correctly when rendering through portals, while others still rely on component-specific handling. This change aligns those implementations and closes the remaining propagation gaps.
Changes
usePortalModeClassesto remaining portaled componentsWhy
This keeps portal behavior consistent across components and reduces the chance of styling mismatches when content is rendered outside the normal DOM tree.
Testing