feat(ENG-11221): modify alpine upstream rsa fields - #284
Open
poconnor-cloud wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CLI table output support for Alpine upstream RSA signature verification fields, aligning cloudsmith upstream alpine ls with newly exposed API configuration properties.
Changes:
- Appends Alpine-only RSA fields to upstream table rows (
rsa_key_inline,rsa_key_url,rsa_verification,rsa_verification_status). - Adds corresponding Alpine-only table headers for the new RSA fields.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
poconnor-cloud
changed the title
Contributor
|
It's worth moving this one back to draft, as without the update to the cloudsmith-api bindings, these changes won't exist yet. Once the API changes are merged, then a new set of bindings can be generated within |
- Simplify the alpine RSA field null-coalescing in print_upstreams() to the single `u.get(...) or ""` idiom already used elsewhere in build_row(), and truncate rsa_key_url like the other unbounded upstream_url/rsa_key_inline columns for consistent table widths. - Add the missing @pytest.mark.integration marker to test_alpine_upstream_ls_pretty_rsa_columns, which calls the live Cloudsmith API but was previously running in neither the unit nor the integration CI job. - Give rsa_key_url a value distinct from upstream_url so the assertion can actually catch a dropped RSA Key URL column, replace the tautological "RSA Verification"/"RSA Verification Status" substring asserts with a single occurrence count, and assert on rendered rsa_verification/rsa_verification_status values to cover the two remaining untested RSA columns. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
BartoszBlizniak
marked this pull request as ready for review
August 26, 2026 16:22
apoclyps
self-requested a review
August 26, 2026 16:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add CLI support for the new RSA signature verification fields on Alpine upstreams. The web-server API now exposes rsa_key_inline, rsa_key_url, rsa_verification, and rsa_verification_status on Alpine upstream configs. This change surfaces those fields in the
cloudsmith upstream alpine lstable output.Create and update commands require no changes since they pass JSON config directly to the API.
Type of Change
Additional Notes
Requires a cloudsmith-api SDK bump when the new SDK version ships with the updated AlpineUpstream model; until then, the fields will gracefully show empty strings via