Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(generic): fix a bug where default values are not set with dynamicgo #1572

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix(generic): fix a bug where default values are not set with dynamicgo #1572

merged 1 commit into from
Oct 14, 2024

Conversation

Marina-Sakai
Copy link
Contributor

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@Marina-Sakai Marina-Sakai requested review from a team as code owners October 11, 2024 10:40
@Marina-Sakai Marina-Sakai merged commit d7a6727 into cloudwego:develop Oct 14, 2024
19 checks passed
@Marina-Sakai Marina-Sakai deleted the fix/dynamicgo_default_value branch October 14, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsterDY AsterDY AsterDY approved these changes

@jayantxie jayantxie jayantxie approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Marina-Sakai @AsterDY @jayantxie