-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skia-canvas 二进制地址已修改导致没有同步 #710
Labels
bug
Something isn't working
Comments
我们已经看到你的反馈,如果是功能缺陷,可以提供一下重现该问题的方式;如果是新功能需求,我们会尽快加入讨论。同时我们非常期待你可以加入我们的贡献者行列,让项目可以长期可持续发展。 |
@ltxhhz 直接提个 pr 😄? |
ltxhhz
added a commit
to ltxhhz/cnpmcore
that referenced
this issue
Oct 10, 2024
ltxhhz
added a commit
to ltxhhz/cnpmcore
that referenced
this issue
Oct 10, 2024
fengmk2
added a commit
that referenced
this issue
Oct 13, 2024
closes #710 pick from #712 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated the `binaries` configuration to include new entries and modified existing ones, enhancing the variety and sources of available binaries. - **Bug Fixes** - Improved the test coverage for the `GithubBinary` class with a new test case to ensure proper fetching of `skia-canvas` release data from GitHub. - **Refactor** - Removed outdated test cases related to the `skia-canvas` package from the `NodePreGypBinary` test suite, streamlining the testing process. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: ltxhhz <ltxhhz@qq.com>
已经成功 https://registry.npmmirror.com/binary.html?path=skia-canvas/ [1/1] scripts.install skia-canvas@latest run "node-pre-gyp install || npm run build -- --release", root: "/Users/fengmk2/git/github.com/cnpm/cnpmcore/node_modules/_skia-canvas@1.0.2@skia-canvas"
(node:28817) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
node-pre-gyp http GET https://cdn.npmmirror.com/binaries/skia-canvas/v1.0.2/darwin-arm64-unknown.tar.gz
[skia-canvas] Success: "/Users/fengmk2/git/github.com/cnpm/cnpmcore/node_modules/_skia-canvas@1.0.2@skia-canvas/lib/v6/index.node" is installed via remote
[1/1] scripts.install skia-canvas@latest finished in 2s
✔ Run 1 scripts
|
非常感谢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
在 skia-canvas 最新的
1.0.2
版本中,二进制地址被修改了,似乎导致 npmmirror binary 没同步成https://github.com/samizdatco/skia-canvas/blob/962f21bd35f06e9477b57cb2a2c1d05a16d35f1a/package.json#L52
直接修改这里的
distUrl
和options
会生效吗cnpmcore/config/binaries.ts
Lines 134 to 142 in e6ed221
The text was updated successfully, but these errors were encountered: