-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change skia-canvas to github release #712
Conversation
WalkthroughThe changes in this pull request involve updates to the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🔇 Additional comments (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
合并到 #715 |
closes #710 pick from #712 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated the `binaries` configuration to include new entries and modified existing ones, enhancing the variety and sources of available binaries. - **Bug Fixes** - Improved the test coverage for the `GithubBinary` class with a new test case to ensure proper fetching of `skia-canvas` release data from GitHub. - **Refactor** - Removed outdated test cases related to the `skia-canvas` package from the `NodePreGypBinary` test suite, streamlining the testing process. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: ltxhhz <ltxhhz@qq.com>
closes #710
Summary by CodeRabbit
New Features
skia-canvas
binary to enhance accessibility.Bug Fixes
requiredNapiVersions
for theskia-canvas
binary, streamlining its usage.