Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: misc router #552

Merged
merged 1 commit into from
Jul 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions app/port/controller/HomeController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,12 @@ import {
} from '@eggjs/tegg';
import { AbstractController } from './AbstractController';
import { CacheService, DownloadInfo, UpstreamRegistryInfo } from '../../core/service/CacheService';
import { NotFoundError, NotImplementedError } from 'egg-errors';

const startTime = new Date();

const NOT_IMPLEMENTED = [ '/-/npm/v1/security/audits/quick', '/-/npm/v1/security/advisories/bulk' ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥要这样黑名单?这样不在黑名单里面的 post 不是也会被攻击么。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些是标记目前暂不支持的方法,返回 501 更贴切一些

其余方法仍默认返回 404


// registry 站点信息数据 SiteTotalData
// SiteEnvInfo: 环境、运行时相关信息,实时查询
// UpstreamInfo: 上游信息,实时查询
Expand Down Expand Up @@ -97,4 +100,18 @@ export class HomeController extends AbstractController {
use: performance.now() - ctx.performanceStarttime!,
};
}

@HTTPMethod({
path: '/*',
method: HTTPMethodEnum.POST,
priority: -Infinity,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这算黑魔法么

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前似乎没有其他方式实现,z-index:1000 😄

})
async misc(@Context() ctx: EggContext) {
const { path } = ctx;
if (NOT_IMPLEMENTED.includes(path)) {
throw new NotImplementedError(`${ctx.path} not implemented yet`);
}

throw new NotFoundError(`${ctx.path} not found`);
}
}
fengmk2 marked this conversation as resolved.
Show resolved Hide resolved
20 changes: 20 additions & 0 deletions test/port/controller/HomeController/misc.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import { app, assert } from 'egg-mock/bootstrap';

describe('test/port/controller/HomeController/misc.test.ts', () => {
describe('[POST /*] misc()', () => {
it('should 501', async () => {
const res = await app.httpRequest()
.post('/-/npm/v1/security/audits/quick')
.expect(501);
assert.equal(res.body.error, '[NOT_IMPLEMENTED] /-/npm/v1/security/audits/quick not implemented yet');
});

it('should 404', async () => {
const res = await app.httpRequest()
.post('/-/greed/is/good')
.expect(404);
assert.equal(res.body.error, '[NOT_FOUND] /-/greed/is/good not found');
});
});

});
fengmk2 marked this conversation as resolved.
Show resolved Hide resolved
Loading