feat: Sync libpg-query binary #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wandergis 感谢贡献，麻烦补充一下测试用例？ 可以参照 test/common/adapter/binary/NodePreGypBinary.test.ts 添加下 |
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
==========================================
- Coverage 97.03% 96.97% -0.06%
==========================================
Files 174 174
Lines 16674 16681 +7
Branches 2194 2190 -4
==========================================
- Hits 16179 16177 -2
- Misses 495 504 +9
|
已添加测试用例 |
fengmk2
approved these changes
Jul 26, 2023
|
@wandergis npm run lint --fix 修复一下 |
done |
fengmk2
pushed a commit
that referenced
this pull request
Jul 27, 2023
[skip ci] ## [3.39.0](v3.38.2...v3.39.0) (2023-07-27) ### Features * Sync libpg-query binary ([#557](#557)) ([8556b5f](8556b5f))
fengmk2
reviewed
Jul 27, 2023
| assert(item.size === '-'); | ||
| assert( | ||
| item.url === | ||
| 'https://supabase-public-artifacts-bucket.s3.amazonaws.com/libpg-query/queryparser-v13.2.1-node-v108-darwin-arm64.tar.gz', |
There was a problem hiding this comment.
@wandergis 这个下载地址不对，应该是 https://supabase-public-artifacts-bucket.s3.amazonaws.com/libpg-query-node/queryparser-v13.1.2-node-v83-darwin-arm64.tar.gz
路径是 libpg-query-node ，而不是 libpg-query
fengmk2
added a commit
to cnpm/binary-mirror-config
that referenced
this pull request
Jul 31, 2023
fengmk2
added a commit
to cnpm/binary-mirror-config
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.