Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: noImplicitAny ts #568

Merged
merged 4 commits into from
Aug 8, 2023
Merged

fix: noImplicitAny ts #568

merged 4 commits into from
Aug 8, 2023

Conversation

elrrrrrrr
Copy link
Member

Attempted to apply the noImplicitAny, parameter types should be specified unless any is manually declared.

  • 🐞 Fixed an issue in bugVersionAdvice where AbbreviatedManifest was being set abnormally.
  • 🤖 Added index.d.ts to store declarations for dependencies without types.
  • 🤔 skipLibCheck has no effect on leoric for now, so it cannot be enabled temporarily.

尝试应用 noImplicitAny 配置,除非手动声明 any,否则需要指定参数类型

  • 🐞 修复 bugVersionAdvice 中,AbbreviatedManifest 设置异常
  • 🤖 添加 index.d.ts 存放无类型依赖声明
  • 🤔 skipLibCheck 对 leoric 失效,暂时无法开启

image

@elrrrrrrr elrrrrrrr added the enhancement New feature or request label Aug 8, 2023
@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/mime-types 2.1.1 None +0 3.85 kB types
@types/npm-package-arg 6.1.1 None +0 7.92 kB types
@types/lodash 4.14.196 None +0 863 kB types

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #568 (1a25928) into master (ab2fde7) will decrease coverage by 0.04%.
Report is 24 commits behind head on master.
The diff coverage is 98.00%.

@@            Coverage Diff             @@
##           master     #568      +/-   ##
==========================================
- Coverage   97.02%   96.99%   -0.04%     
==========================================
  Files         174      175       +1     
  Lines       16588    16752     +164     
  Branches     2177     2200      +23     
==========================================
+ Hits        16095    16248     +153     
- Misses        493      504      +11     
Files Changed Coverage Δ
app/port/webauth/WebauthController.ts 85.59% <78.94%> (+0.53%) ⬆️
app/common/PackageUtil.ts 97.61% <90.90%> (-1.42%) ⬇️
app/common/FileUtil.ts 100.00% <100.00%> (ø)
app/common/UserUtil.ts 100.00% <100.00%> (ø)
app/common/adapter/CacheAdapter.ts 100.00% <100.00%> (ø)
app/common/adapter/NPMRegistry.ts 100.00% <100.00%> (ø)
app/common/adapter/binary/AbstractBinary.ts 94.17% <100.00%> (+0.11%) ⬆️
app/common/adapter/binary/NodePreGypBinary.ts 98.69% <100.00%> (+<0.01%) ⬆️
app/common/adapter/binary/PlaywrightBinary.ts 99.26% <100.00%> (+0.03%) ⬆️
...on/adapter/changesStream/CnpmjsorgChangesStream.ts 100.00% <100.00%> (ø)
... and 29 more

... and 2 files with indirect coverage changes

Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

开启了 hard 模式

@fengmk2 fengmk2 merged commit 1932bb9 into master Aug 8, 2023
11 of 12 checks passed
@fengmk2 fengmk2 deleted the fix-ts branch August 8, 2023 12:42
fengmk2 pushed a commit that referenced this pull request Aug 8, 2023
[skip ci]

## [3.39.5](v3.39.4...v3.39.5) (2023-08-08)

### Bug Fixes

* noImplicitAny ts ([#568](#568)) ([1932bb9](1932bb9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants