fix: fix breaking change about RSA_PKCS1_PADDING. #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/egg-scripts@2.17.0 |
|
是否可以将 RSA_PKCS1_PADDING 改掉？ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #650 +/- ##
=======================================
Coverage 96.84% 96.84%
=======================================
Files 180 180
Lines 17598 17598
Branches 2292 2292
=======================================
Hits 17043 17043
Misses 555 555 ☔ View full report in Codecov by Sentry. |
这个我不大清楚改掉是否可行，但是通过更新egg-scripts传入revert参数，目前程序是可以正常使用的，可以解决这个报错。 |
|
另外补充一下，该问题会导致用户无法登录，接口会返回500。 |
fengmk2
pushed a commit
that referenced
this pull request
Feb 20, 2024
[skip ci] ## [3.53.1](v3.53.0...v3.53.1) (2024-02-20) ### Bug Fixes * fix breaking change about RSA_PKCS1_PADDING ([#650](#650)) ([a6737e6](a6737e6))
|
@hljwkwm 我准备将 CVE-2023-46809 删除，这个会引发安全问题，cnpmcore 并没有依赖这个能力。 |
fengmk2
added a commit
that referenced
this pull request
May 16, 2024
revert #650 run test on Node.js 22
Get✅ |
fengmk2
added a commit
that referenced
this pull request
May 16, 2024
use RSA_PKCS1_OAEP_PADDING instead of RSA_PKCS1_PADDING revert #650 run test on Node.js 22
fengmk2
added a commit
that referenced
this pull request
May 17, 2024
use node-rsa instead of RSA_PKCS1_PADDING revert #650 run test on Node.js 22
fengmk2
added a commit
that referenced
this pull request
May 17, 2024
use node-rsa instead of RSA_PKCS1_PADDING revert #650 run test on Node.js 22
fengmk2
added a commit
that referenced
this pull request
May 17, 2024
revert #650 run test on Node.js 22 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated Node.js version support to 18, 20, and 22. - Removed unnecessary configuration from the release workflow. - Cleaned up outdated security-related entries in the package configuration. - Updated encryption functions in CryptoUtil.ts for improved security. - Refactored import statements for ES module syntax in webauthController.test.ts. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题：
Node.JS安全性修复导致RSA_PKCS1_PADDING不可用，会报出以下错误：
该PR用于修复以上问题。
参考链接：https://www.eggjs.org/zh-CN/core/security#revert-cve