Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run test on Node.js 22 #682

Closed
wants to merge 1 commit into from
Closed

test: run test on Node.js 22 #682

wants to merge 1 commit into from

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented May 16, 2024

Summary by CodeRabbit

  • Chores
    • Updated Node.js version support to include versions 18, 20, and 22.
    • Removed obsolete test check configuration from the release workflow.

Copy link
Contributor

coderabbitai bot commented May 16, 2024

Walkthrough

The recent updates focus on modifying GitHub Actions workflows. The node-version matrix in the nodejs.yml file has been updated to include newer Node.js versions, ensuring compatibility and future-proofing the project. Additionally, the release.yml workflow has been simplified by removing the checkTest: false configuration, streamlining the release process.

Changes

File Change Summary
.github/workflows/nodejs.yml Updated node-version matrix from [16, 18, 20] and [18, 20, 21] to [18, 20, 22].
.github/workflows/release.yml Removed the checkTest: false configuration from the jobs section.

🐰
In the land of code, where versions grow,
We update Node, to keep the flow.
From sixteen's charm, to twenty-two's might,
Our workflows shine, ever so bright.
Release with ease, no tests to bind,
A smoother path, for peace of mind.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 65d6f44 and 08fdb34.
Files selected for processing (2)
  • .github/workflows/nodejs.yml (2 hunks)
  • .github/workflows/release.yml (1 hunks)
Files skipped from review due to trivial changes (2)
  • .github/workflows/nodejs.yml
  • .github/workflows/release.yml

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.83%. Comparing base (65d6f44) to head (08fdb34).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
- Coverage   96.88%   96.83%   -0.06%     
==========================================
  Files         181      181              
  Lines       17867    17867              
  Branches     2314     2304      -10     
==========================================
- Hits        17311    17302       -9     
- Misses        556      565       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengmk2 fengmk2 closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant