Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin.xml: Rename 'coala-analyzer.gif' #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

plugin.xml: Rename 'coala-analyzer.gif' #30

wants to merge 1 commit into from

Conversation

thotayashwanth123
Copy link

Closes #27

SiddharthKumar02
SiddharthKumar02 reviewed Feb 2, 2017
View reviewed changes
Copy link
Member

@SiddharthKumar02 SiddharthKumar02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thotayashwanth123 Your commit head is more than 50 characters long. Make it shorter. Your changes look alright to me :)

@sils
Copy link
Member

sils commented Feb 2, 2017

missing space before the colon FWIW

damngamerz
damngamerz reviewed Feb 5, 2017
View reviewed changes
com.coala.core/plugin.xml
@@ -57,7 +57,7 @@
<menuContribution
locationURI="popup:org.eclipse.ui.popup.any?after=additions">
<menu
icon="icons/coala-analyzer.gif"
icon="icons/coala.gif"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In icons folder the file is named to be "coala-analyzer.gif" rename it to "coala.gif" might possibly fix the issue as well as ci failure!!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it, but again Travis is failling

Copy link
Member

@damngamerz damngamerz Feb 5, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thotayashwanth123 changed and committed the changes? still its failing..I cannot see your rename file commit!! can you plz do it so i can see trace back!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to rename this file https://github.com/coala/coala-eclipse/blob/master/com.coala.core/icons/coala-analyzer.gif to coala.gif

meetmangukiya
meetmangukiya requested changes Feb 5, 2017
View reviewed changes
com.coala.core/plugin.xml
@@ -57,7 +57,7 @@
<menuContribution
locationURI="popup:org.eclipse.ui.popup.any?after=additions">
<menu
icon="icons/coala-analyzer.gif"
icon="icons/coala.gif"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to rename this file https://github.com/coala/coala-eclipse/blob/master/com.coala.core/icons/coala-analyzer.gif to coala.gif

@thotayashwanth123 thotayashwanth123 changed the title plugin.xml: Rename 'coala-analyzer.gif' to 'coala.gif' plugin.xml: Rename 'coala-analyzer.gif' Feb 10, 2017
@arjunsinghy96
Copy link

You need to rebase your branch. It is 11 commits behind and is missing one critical commit for travis fix.
Try running git rebase master in your branch as it is even with coala:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damngamerz damngamerz damngamerz left review comments

@SiddharthKumar02 SiddharthKumar02 SiddharthKumar02 left review comments

@meetmangukiya meetmangukiya meetmangukiya requested changes

Assignees
No one assigned
Labels
process/wip status/STALE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@thotayashwanth123 @sils @arjunsinghy96 @meetmangukiya @damngamerz @SiddharthKumar02 @gitmate-bot