Skip to content

Commit

Permalink
appstream: Fix validation problems
Browse files Browse the repository at this point in the history
Rename the file to match its ID, fix the ID, add developer tag, and
extend the description. This fixes all issues with `appstreamcli validate`:

> org.cockpit-project.files.metainfo.xml
>  I: org.cockpit_project.cockpit_files:22: description-first-para-too-short
>       A file system browser for Cockpit.
>  I: org.cockpit_project.cockpit_files: developer-info-missing
>  W: org.cockpit_project.cockpit_files: metainfo-filename-cid-mismatch
  • Loading branch information
martinpitt committed Oct 11, 2024
1 parent 3b76e01 commit 3108f10
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ TARFILE=$(RPM_NAME)-$(VERSION).tar.xz
NODE_CACHE=$(RPM_NAME)-node-$(VERSION).tar.xz
SPEC=$(RPM_NAME).spec
PREFIX ?= /usr/local
APPSTREAMFILE=org.cockpit-project.$(PACKAGE_NAME).metainfo.xml
APPSTREAMFILE=org.cockpit_project.$(PACKAGE_NAME).metainfo.xml
VM_IMAGE=$(CURDIR)/test/images/$(TEST_OS)
# stamp file to check for node_modules/
NODE_MODULES_TEST=package-lock.json
Expand Down
Original file line number Diff line number Diff line change
@@ -1,17 +1,23 @@
<?xml version="1.0" encoding="UTF-8"?>
<component type="addon">
<id>org.cockpit_project.cockpit_files</id>
<id>org.cockpit_project.files</id>
<metadata_license>CC0-1.0</metadata_license>
<name>Files</name>
<summary>Manage your files</summary>
<description>
<p>
A file system browser for Cockpit.
A file system UI for Cockpit.

You can browse directories, upload and download files, and change their properties.
It also includes a simple file editor.
</p>
</description>
<extends>org.cockpit_project.cockpit</extends>
<launchable type="cockpit-manifest">files</launchable>
<url type="homepage">https://github.com/cockpit-project/cockpit-files</url>
<url type="bugtracker">https://github.com/cockpit-project/cockpit-files/issues</url>
<update_contact>cockpit-devel_AT_lists.fedorahosted.org</update_contact>
<developer id="org.cockpit-project">
<name>Cockpit Project</name>
</developer>
</component>

0 comments on commit 3108f10

Please sign in to comment.