Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: support Arch Linux's chromium binary name in BiDi, Don't change context in WebdriverBidi.restore_context() #20907

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Aug 19, 2024

Addresses a late comment from @mvollmer in #20832 (review)

jelly and others added 2 commits August 19, 2024 09:44
On Arch Linux chromium can be found in /usr/bin/chromium.
That was a bit strange indeed. Do it explicitly instead.
Copy link
Member

@mvollmer mvollmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mvollmer mvollmer merged commit 0b1585b into cockpit-project:main Aug 20, 2024
73 checks passed
@martinpitt martinpitt deleted the bidi-fixes branch August 20, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants