Skip to content

Submission get_detail API: Restrict to submission owner or admin - #2525

Open
ihsaan-ullah wants to merge 1 commit into
developfrom
submission_detail_api
Open

Submission get_detail API: Restrict to submission owner or admin#2525
ihsaan-ullah wants to merge 1 commit into
developfrom
submission_detail_api

Conversation

@ihsaan-ullah

Copy link
Copy Markdown
Collaborator

Description

Anonymous and non-owner requests could previously view submission details when hide_output was off. Now only the owner or an admin can access them. Adds tests covering the fix.

Issues this PR resolves

  • reported by Chris Haris and Wenhao Deng

A checklist for hand testing

  • Call the api with an anonymous user and check that you do not get access to the submission.

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

Anonymous and non-owner requests could previously view submission
details when hide_output was off. Now only the owner or an admin
can access them. Adds tests covering the fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant