Fix build on macOS: Apple clang C++ standard and PyQt6 tools detection - #169
Open
florian-simvia wants to merge 2 commits into
Open
Fix build on macOS: Apple clang C++ standard and PyQt6 tools detection#169florian-simvia wants to merge 2 commits into
florian-simvia wants to merge 2 commits into
Conversation
Apple clang version numbers don't follow the LLVM's and its default standard is still C++14, so the version test in cs_auto_flag.sh missed it and compilation stopped on std::is_same_v in cs_defs.h. Force -std=c++17 when the compiler identifies as Apple.
In configure.ac, a typo ("xPyQt5" instead of "xPyQt6") disabled the detection of the PyQt6 dev tools, so GUI builds with PyQt6 failed with "--pyrcc must be set". Affects Linux too, not just macOS. configure must be regenerated with ./sbin/bootstrap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building from source on macOS currently fails for two unrelated reasons.
Apple clang version numbers don't follow LLVM's, and its default standard is still C++14, so the
14* | 15*test incs_auto_flags.shdoesn't catch it and compilation stops onstd::is_same_vincs_defs.h. I added a case for version strings containingAppleto force-std=c++17.In configure.ac, a typo (
xPyQt5instead ofxPyQt6) disables the detection of thePyQt6dev tools, so GUI builds with PyQt6 fail with--pyrcc must be set. This affects Linux too, not just macOS.configuremust be regenerated with./sbin/bootstrap.With these two changes, I get a complete build (solver + GUI) on macOS 15.7/Apple Silicon with the Homebrew toolchain, PyQt6 and
--diable-shared, and cases run fine.