fix: add robust test for --recurse-submodules plumbing - #762
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
AttributeError: 'NoneType' object has no attribute 'kwargs'reported in issue CLI-GC. The root cause was identified as a test (or validation script) invoking theupload-coverageCLI command without satisfying its required arguments (specifically--commit-sha). This caused the CLI to exit withSystemExit(2), preventingupload_coverage_logicfrom being called, and thusmock_logic.call_argsreturnedNone. Subsequent access to.kwargson thisNoneobject led to theAttributeError.Instead of modifying an external
validate_cli.pyscript, a new, robust test casetest_upload_coverage_recurse_submodules_flag_plumbinghas been added totests/commands/test_invoke_upload_coverage.py. This new test:--commit-shato ensure the CLI invocation succeeds.get_ci_adapterandget_versioning_systemto create a controlled test environment, independent of actual git or CI configurations.result.exit_code == 0immediately after the CLI invocation to catch any command-line parsing errors early.call is not Nonebefore attempting to accesscall.kwargs, preventing theAttributeError.recurse_submodulesargument is correctly passed toupload_coverage_logicwhen the flag is both present and absent.Fixes CLI-GC
This PR was automatically generated by Sentry. You can adjust this setting at any time.