fix: Remove build_code fallback for --name option - #765
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies the
--nameoption in thecodecov_cli/commands/upload.pycommand to removeFallbackFieldEnum.build_codefrom its fallback chain. Previously, ifjob_namewas not available,--namewould fall back to thebuild_code.The original intent behind introducing
job_nameas a fallback (commitf7cb28c4) was to provide a more human-readable name for uploads, moving away from generic numeric build IDs. By removingbuild_codeas a secondary fallback, the--nameoption will now only auto-populate ifjob_nameis available (e.g., on GitHub Actions, whereGITHUB_WORKFLOWandGITHUB_JOBare used). For other CI providers where_get_job_nameis not implemented,--namewill default toNoneif not explicitly provided by the user, aligning with the goal of either a meaningful name or no auto-population.Fixes CLI-GE
This PR was automatically generated by Sentry. You can adjust this setting at any time.