Skip to content

fix: Remove build_code fallback for --name option - #765

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/remove-name-build-code-fallback
Open

fix: Remove build_code fallback for --name option#765
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/remove-name-build-code-fallback

Conversation

@sentry

@sentry sentry Bot commented Aug 20, 2026

Copy link
Copy Markdown

This change modifies the --name option in the codecov_cli/commands/upload.py command to remove FallbackFieldEnum.build_code from its fallback chain. Previously, if job_name was not available, --name would fall back to the build_code.

The original intent behind introducing job_name as a fallback (commit f7cb28c4) was to provide a more human-readable name for uploads, moving away from generic numeric build IDs. By removing build_code as a secondary fallback, the --name option will now only auto-populate if job_name is available (e.g., on GitHub Actions, where GITHUB_WORKFLOW and GITHUB_JOB are used). For other CI providers where _get_job_name is not implemented, --name will default to None if not explicitly provided by the user, aligning with the goal of either a meaningful name or no auto-population.

Fixes CLI-GE

This PR was automatically generated by Sentry. You can adjust this setting at any time.

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
723 1 722 1
View the full list of 1 ❄️ flaky test(s)
api.temp.calculator.test_calculator::test_divide

Flake rate in main: 100.00% (Passed 0 times, Failed 1726 times)

Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants