fix: gracefully handle missing files during upload - #766
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue CLI-3E, where the Codecov CLI would crash with a
FileNotFoundErrorif a coverage file, discovered during the search phase, was no longer present or accessible when its content was being read for upload.The root cause was a TOCTOU (Time-of-Check to Time-of-Use) race condition: a file like
coverage.jsonmight be found by the file search, but then deleted or become a broken symlink before the upload process could read its content. The previous implementation in_get_filesinupload_sender.pydid not handle this scenario, leading to an unhandled exception and a failed upload.Changes Made:
_get_filesmethod incodecov_cli/services/upload/upload_sender.py.self._format_file(file)) in atry-except FileNotFoundErrorblock.FileNotFoundErroroccurs for a specific file, a warning is now logged (e.g., "File not found, skipping: /path/to/missing/file"), and that file is skipped, allowing the upload of other valid files to proceed without interruption.Fixes CLI-3E
This PR was automatically generated by Sentry. You can adjust this setting at any time.