fix: prevent AttributeError when ctx.obj is None in CodecovOption.get_default - #768
Open
sentry[bot] wants to merge 1 commit into
Open
fix: prevent AttributeError when ctx.obj is None in CodecovOption.get_default#768sentry[bot] wants to merge 1 commit into
ctx.obj is None in CodecovOption.get_default#768sentry[bot] wants to merge 1 commit into
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an
AttributeError: 'NoneType' object has no attribute 'get'that occurred when runningcodecov-cli --helporcodecov-cli <command> --help.The root cause was that Click's help rendering mechanism calls
CodecovOption.get_defaultbefore thectx.obj(which holdsci_adapter,versioning_system, etc.) is fully initialized. This resulted inctx.objbeingNonewhen the code attempted to call.get()on it.The fix adds a check for
ctx.obj is not Noneincodecov_cli/fallbacks.pywithin theCodecovOption.get_defaultmethod. This ensures that the fallback logic, which relies onctx.obj, is only executed whenctx.objis a valid object, thus preventing theAttributeError.Fixes CLI-GG
This PR was automatically generated by Sentry. You can adjust this setting at any time.