fix: handle UnicodeDecodeError in git ls-files output - #773
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
UnicodeDecodeErroroccurring inGitVersioningSystem.list_relevant_fileswhen processing the output ofgit ls-files -z.Previously,
res.stdout.decode()was used without an error handler, causing the CLI to crash ifgit ls-files -zreturned filenames containing byte sequences that were not valid UTF-8. This can happen with filesystems or repositories where filenames use non-UTF-8 encodings (e.g., Latin-1).The fix modifies the
decode()call tores.stdout.decode(errors="replace"). This ensures that any invalid byte sequences encountered during decoding are replaced with the Unicode replacement character (\ufffd) instead of raising an error. This makes the CLI more robust and prevents crashes when encountering such filenames, allowing the upload process to complete successfully.Fixes CLI-AK
This PR was automatically generated by Sentry. You can adjust this setting at any time.