feat(graphql): allow owner query by ownerid - #2019
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
Contributor
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2019 +/- ##
==========================================
- Coverage 91.63% 91.62% -0.02%
==========================================
Files 1336 1336
Lines 53230 53242 +12
Branches 1647 1647
==========================================
+ Hits 48778 48783 +5
- Misses 4131 4138 +7
Partials 321 321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the
ownerGraphQL field to allow querying byowneridin addition tousername.Previously, the
ownerfield in the GraphQL API only accepted a requiredusername: String!argument. This led toGraphQLErrorexceptions when clients attempted to query for an owner using anownerid.This change modifies the
ownerfield to accept eitherusername: Stringorownerid: Int(both optional, but at least one must be provided). A newget_owner_by_idaction was introduced, and theresolve_ownerresolver was updated to handle both arguments, ensuring that the correct owner lookup is performed based on the provided identifier.This resolves the issue where clients were unable to query owners by their numerical ID.
Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes API-EWB
This PR was automatically generated by Sentry. You can adjust this setting at any time.