Skip to content

fix: prevent TypeError when Salesforce content[0] is None - #2023

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-z6v-salesforce-none-check
Open

fix: prevent TypeError when Salesforce content[0] is None#2023
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-z6v-salesforce-none-check

Conversation

@sentry

@sentry sentry Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

This PR addresses issue WORKER-Z6V, a TypeError: argument of type 'NoneType' is not iterable occurring in app.tasks.upload.UploadProcessor.

The root cause was identified in services/report/languages/salesforce.py, specifically within the SalesforceProcessor.matches_content method. The method was attempting to perform a membership test ("name" in content[0]) on content[0] without first verifying that content[0] was not None.

The parsed_report for certain Salesforce uploads could contain None as its first element (e.g., [None, {...}]). When content[0] was None, the in operator raised a TypeError because NoneType is not iterable.

This fix adds an explicit check (content[0] is not None) to ensure that content[0] is a valid iterable before attempting the membership test, thus preventing the TypeError.

Legal Boilerplate

Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.

Fixes WORKER-Z6V

This PR was automatically generated by Sentry. You can adjust this setting at any time.

@thomasrockhu-codecov

Copy link
Copy Markdown
Contributor
✨ Harness AI Code Review View in Harness →

ℹ️ Review in progress — analyzing the changes on this pull request.
This comment updates automatically when the review finishes.

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.63%. Comparing base (a8ec2db) to head (3f64a32).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2023   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files        1336     1336           
  Lines       53230    53230           
  Branches     1647     1647           
=======================================
  Hits        48778    48778           
  Misses       4131     4131           
  Partials      321      321           
Flag Coverage Δ
workerintegration 58.49% <0.00%> (ø)
workerunit 90.55% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codecov-notifications

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant