fix(torngit): guard against NoneType in _get_raw_pull_request_commits - #2026
Open
sentry[bot] wants to merge 1 commit into
Open
fix(torngit): guard against NoneType in _get_raw_pull_request_commits#2026sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2026 +/- ##
=======================================
Coverage 91.63% 91.63%
=======================================
Files 1336 1336
Lines 53230 53230
Branches 1647 1647
=======================================
Hits 48778 48778
Misses 4131 4131
Partials 321 321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
TypeError: object of type 'NoneType' has no len()occurring inapp.tasks.test_results.TestResultsFinisherTask.The root cause is in
libs/shared/shared/torngit/github.py, specifically within the_get_raw_pull_request_commitsmethod. Theself.api()call on line 1602 can returnNonewhen the GitHub API responds with an HTTP 204 (No Content) status. Subsequently, thelen(page_results)checks on lines 1603 and 1605 attempt to calllen()on thisNoneobject, leading to theTypeError.The fix involves adding
or []to the assignment ofpage_resultson line 1602. This ensures that ifself.api()returnsNone,page_resultsdefaults to an empty list, preventing theTypeErrorwhenlen()is called.Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes WORKER-Z30
This PR was automatically generated by Sentry. You can adjust this setting at any time.