Skip to content

fix(Table): Remove non-color variants from colorVariants - #518

Open
Mintoo200 wants to merge 1 commit into
codegouvfr:mainfrom
Mintoo200:fix-table-color-variant
Open

fix(Table): Remove non-color variants from colorVariants#518
Mintoo200 wants to merge 1 commit into
codegouvfr:mainfrom
Mintoo200:fix-table-color-variant

Conversation

@Mintoo200

Copy link
Copy Markdown

Namely "sm", "lg" and "multiline"

@Mintoo200

Copy link
Copy Markdown
Author

This technically is a breaking change. Plus sm, lg and multiline are not implemented yet, so anyone using these variants would be currently using them via colorVariant. How do you want to handle that ? I could add props for these, but that would not solve the issue of it being a breaking change 馃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant