fix(agents): hide async hook console window on Windows - #501
Open
put4o wants to merge 1 commit into
Open
Conversation
Add windowsHide to asynchronous shell hook processes so detached sh.exe processes do not flash a console window on Windows. Fixes codemie-ai#494
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent asynchronous shell hooks from briefly opening a
sh.execonsole window on Windows.Motivation
execCommandAsync()starts asynchronous hook commands using a detachedshprocess. On Windows,detached: truedoes not suppress the console window created for the child process, causingsh.exeto briefly flash during normalcodemie-opencodeusage.Changes
windowsHide: trueto thespawn()options used by asynchronous shell hooks.Testing
npm run lint— passednpm run build— passednpm run commitlint:last— passedwindowsHide: true— passednpm run ci— completed with 6 pre-existing failures inshell-hooks-source.test.tson native WindowsBreaking Changes
None.
Related Issues
Fixes #494