馃 fix: hide resolved comment threads by default in diff view - #26
Open
ibetitsmike wants to merge 2 commits into
Open
馃 fix: hide resolved comment threads by default in diff view#26ibetitsmike wants to merge 2 commits into
ibetitsmike wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved review threads in the diff view now start collapsed behind a "Resolved by X" header, expandable via the chevron.
Why the existing collapse UI never triggered
CommentThreadalready had collapse logic keyed onReviewComment.is_resolved, but that field (declared "enriched from GraphQL") was never populated: REST review comments carry no thread ID or resolution state. Every thread therefore rendered as unresolved, and the diff view's Resolve button never appeared sincepull_request_review_thread_idwas always undefined.Implementation notes
enrichCommentsWithThreadsjoins the already-fetched GraphQL review threads (isResolved,resolvedBy, thread ID) onto REST comments bydatabaseId. Applied at initial PR load and in the post-review-submit refresh, which previously would have wiped resolution state. No extra API calls on initial load.isResolved(no expand-then-collapse flash) and re-syncs when resolution changes from another view, so a thread cannot get stuck collapsed with the expand chevron hidden.useThreadActionsnow updates bothcomments(diff view) andreviewThreads(overview); the overview's inline resolve handlers were replaced with this shared hook so the two views cannot drift.Validation
bun test(47 pass, includes 3 new data-layer tests for the enrichment join),bun typecheck,bun fmtall clean.